Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Fix android sonar cloud bugs #178

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

med-S
Copy link
Collaborator

@med-S med-S commented Nov 14, 2022

No description provided.

@dedece35
Copy link
Collaborator

hello @med-S, please check your failed checks above.

@jhertout, I have the same error in my local environment. Can you review this PR please ? for me it's ok.

@dedece35 dedece35 added bug Something isn't working plugin:android Specific to the Android plugin labels Nov 18, 2022
@med-S
Copy link
Collaborator Author

med-S commented Nov 18, 2022

Hello @dedece35, thanks for the comment.
In fact, I had this issue in the main branch and I created this branch to try and fix it
I’m working on it to see what I can do

@dedece35
Copy link
Collaborator

dedece35 commented Nov 18, 2022

@med-S,
ok thank you for explanation.

I think we have to define best practices for contribution. For example, to have a fork, then create a branch to make development, and finally, make a PR from branch of personal fork to main of origin repository. The purpose is that mainteners people can review PR before merging in main branch of origin repository.
What do you think about it @glalloue, @jules-delecour-dav ?

@dedece35
Copy link
Collaborator

dedece35 commented Nov 28, 2022

Hi @med-S,
we are migrating this repo to a new one : please see green-code-initiative/ecoCode-android#3
that's why I change this PR to "draft".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working migrated_to_new_mobile_repo if is migrated to new mobile repo plugin:android Specific to the Android plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants