This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Grsp0007 php #114
Draft
Grsp0007 php #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuSh
reviewed
Jun 3, 2022
| import java.util.*; | ||
|
|
||
| @Rule( | ||
| key = "GRSP0008", |
There was a problem hiding this comment.
Il semblerait que cette PR inclut également votre précédente PR #110
|
|
||
| public void checkIssue(ForStatementTree forStatementTree) { | ||
| if(forStatementTree.forToken() != null){ | ||
| repport(forStatementTree); |
There was a problem hiding this comment.
Il y a une typo dans le fichier d'origine mais il n'est pas nécessaire de la réitérer ;)
Suggested change
| repport(forStatementTree); | |
| report(forStatementTree); |
|
SonarCloud Quality Gate failed. |
|
Bonjour @mouradmamassi , merci de prendre en comptes les retours de @KuSh ainsi que de corriger les pbs cités ci-dessus, SVP. merci à vous. (for information, we are migrating this repo to a new one : https://github.com/green-code-initiative/ecocode-mobile, I will report your modifications manually) |
|
Hi @mouradmamassi , |
dedece35
added
the
migrated_to_new_standrad_repo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To review GRSP0007 - [PHP] - Préférer l'utilisation de foreach