Test: Verify if configmaps are encrypted #1996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haskojur
requested review from
denverwilliams,
wvwatson and
agentpoyo
as code owners
haskojur
changed the title
haskojur
changed the title
haskojur
force-pushed
the
securedConfigmaps
branch
from
2b64438
to
2057fc3
Compare
haskojur
force-pushed
the
securedConfigmaps
branch
from
2057fc3
to
bec200b
Compare
haskojur
changed the title
|
@HashNuke can you give me a feedback for this one please? :) |
martin-mat
requested changes
May 14, 2024
| @@ -83,4 +83,16 @@ describe "Platform" do | |||
| $?.success?.should be_true | |||
| (/PASSED: No Helm Tiller containers are running/ =~ response_s).should_not be_nil | |||
| end | |||
|
|
|||
| it "'verify_configmaps_encryption' should pass if encryption is enabled in etcd", tags: ["platform:security"] do | |||
There was a problem hiding this comment.
the idea of spec test in this repo is to run complete test cases by command-line, so I'd suggest to follow it also with this newly added test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default in kubernetes system, encrypting of data inside object like configmaps is not enabled, so data in etcd are available for potential attacker.
Encrypting of configmaps is possible in newer versions of kubernetes. When this configuration is done, all newly created configmaps has encrypted data in etcd key-value store.
This testcase creates new sonfigmap with random suffix (to avoid confilct). Then we will use similar command in etcd pod to verify if encryption is working:
ETCDCTL_API=3 etcdctl \ --cacert=/etc/kubernetes/pki/etcd/ca.crt \ --cert=/etc/kubernetes/pki/etcd/server.crt \ --key=/etc/kubernetes/pki/etcd/server.key \ get /registry/configmaps/default/my-configmap | hexdump -CIssues:
Refs: #1994
How has this been tested:
Types of changes:
Checklist:
Documentation
Code Review
Issue