WIP: Improved version of CNOE AWS Reference Implementation #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
tehlers320
reviewed
Jul 2, 2025
tehlers320
reviewed
Jul 2, 2025
tehlers320
reviewed
Jul 2, 2025
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
|
@tehlers320 Thank you for feedback, Updated the instructions. |
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
nusnewob
reviewed
Jul 9, 2025
There was a problem hiding this comment.
In general I'm happy to see many previous issues are being addressed in this PR,
- terraform code is now decoupled with k8s resources
- all components are managed using helm charts instead of plain yaml manifest
- cleaner values for charts, instead of overrides from various places
However in my opinion installing using idpbuilder should be discouraged, since it lacks of all the progress has been made in this PR.
| public_subnets = [for k, v in local.azs : cidrsubnet(local.vpc_cidr, 8, k + 48)] | ||
|
|
||
| enable_nat_gateway = true | ||
| single_nat_gateway = true |
There was a problem hiding this comment.
single NAT Gateway may be cost efficient, but NAT Gateway per AZ would be more resilient.
| @@ -0,0 +1,78 @@ | |||
| {{- if .Values.postgresql.enabled -}} | |||
There was a problem hiding this comment.
why not using existing postgres chart?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Improved version of CNOE AWS Reference Implementation
Fixes: #49