add peer dependency

avoid calling the same function multiple times
cnoe-io · Aug 2, 2023 · ddc975a · ddc975a
1 parent 76a8230
commit ddc975a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -37,6 +37,9 @@
     "react-router-dom": "6.0.0-beta.0 || ^6.3.0",
     "yaml": "^2.3.1"
   },
+  "peerDependencies": {
+    "react": "^16.13.1 || ^17.0.0"
+  },
   "devDependencies": {
     "@backstage/cli": "^0.22.9",
     "@backstage/core-app-api": "^1.9.0",

diff --git a/src/components/DetailedDrawer/DrawerOverview.tsx b/src/components/DetailedDrawer/DrawerOverview.tsx
@@ -77,23 +77,24 @@ const upperCaseFirstChar = (s: string) => {
 };
 
 export const DrawerOverview = (props: { sparkApp: ApacheSpark }) => {
+  const data = generateMetadata(props.sparkApp)
   return (
     <div className={useStyles().content}>
       <InfoCard title="Apache Spark Application">
         <StructuredMetadataTable
-          metadata={generateMetadata(props.sparkApp).app}
+          metadata={data.app}
           options={{ titleFormat: upperCaseFirstChar }}
         />
       </InfoCard>
       <InfoCard title="Driver">
         <StructuredMetadataTable
-          metadata={generateMetadata(props.sparkApp).driver}
+          metadata={data.driver}
           options={{ titleFormat: upperCaseFirstChar }}
         />
       </InfoCard>
       <InfoCard title="Executors">
         <StructuredMetadataTable
-          metadata={generateMetadata(props.sparkApp).executor}
+          metadata={data.executor}
           options={{ titleFormat: upperCaseFirstChar }}
         />
       </InfoCard>