Fix wrong argocd project name from idpbuilder-embedded-gitserver to idpbuilder-local-gitserver

[cmoulliard]

• Issue: ArgoCD crossplane application fails to be deployed as it uses a wrong Argocd project name #42
• Fix wrong argocd project name from idpbuilder-embedded-gitserver to idpbuilder-local-gitserver for Crossplane

ARGOCD_SERVER=argocd.idpbuilder.cnoe.io.localtest.me:8443
ARGOCD_USER=admin
ARGOCD_PWD=$(kubectl -n argocd get secret argocd-initial-admin-secret -o jsonpath="{.data.password}" | base64 -d)

argocd login --insecure $ARGOCD_SERVER --username $ARGOCD_USER --password $ARGOCD_PWD
'admin:login' logged in successfully
Context 'argocd.idpbuilder.cnoe.io.localtest.me:8443' updated

argocd app list
NAME                                             CLUSTER                         NAMESPACE          PROJECT                     STATUS  HEALTH   SYNCPOLICY  CONDITIONS  REPO                                                                     PATH           TARGET
argocd/crossplane-helm                           https://kubernetes.default.svc  crossplane-system  idpbuilder-local-gitserver  Synced  Healthy  Auto-Prune  <none>      https://charts.crossplane.io/stable                                                     1.11.1
argocd/idpbuilder-local-gitserver-argocd         https://kubernetes.default.svc  argocd             idpbuilder-local-gitserver  Synced  Healthy  Auto        <none>      http://gitserver-embedded.idpbuilder-local.svc/idpbuilder-resources.git  argocd         HEAD
argocd/idpbuilder-local-gitserver-backstage      https://kubernetes.default.svc  argocd             idpbuilder-local-gitserver  Synced  Healthy  Auto        <none>      http://gitserver-embedded.idpbuilder-local.svc/idpbuilder-resources.git  backstage      HEAD
argocd/idpbuilder-local-gitserver-crossplane     https://kubernetes.default.svc  argocd             idpbuilder-local-gitserver  Synced  Healthy  Auto        <none>      http://gitserver-embedded.idpbuilder-local.svc/idpbuilder-resources.git  crossplane     HEAD
argocd/idpbuilder-local-gitserver-nginx-ingress  https://kubernetes.default.svc  argocd             idpbuilder-local-gitserver  Synced  Healthy  Auto        <none>      http://gitserver-embedded.idpbuilder-local.svc/idpbuilder-resources.git  nginx-ingress  HEAD

[nabuskey]

App project name is set here:

idpbuilder/pkg/controllers/localbuild/controller.go

Lines 235 to 241 in 59570de

	localbuild.SetApplicationSpec(
	app,
	repoUrl,
	embedApp.Path,
	resource.GetArgoProjectName(),
	nil,
	)

This works for pure manifests, but doesn't work for Crossplane which is defined as an Argo App. The project name is part determined by the flag --buildName so project name could be different between runs.

We could:

1. Use the default project for all or part of our apps.
2. Attempt to correct this in code when we come across an argo app.

@greghaynes Thoughts?

[cmoulliard]

1. Use the default project for all or part of our apps.

I would like to suggest to use the same ArgoCD project at the moment as this project will be used to install top of argoCD the core components and next the pluggable components. If later, it is needed to have 2 Argocd projects; one to manage the core components and another for the pluggable, then we could reconsider this choice.

[greghaynes]

Good find. I think when we do pluggable packages we will also be able to fix this. I think your suggestion of using the default name everywhere makes sense as a temporary fix until then.

[cmoulliard]

Can we merge it before to release the first alpha cutoff ? @nabuskey @greghaynes