-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify log format for readability #423
base: main
Are you sure you want to change the base?
Conversation
fixes cnoe-io#395 Signed-off-by: Nima Kaviani <[email protected]>
We can do that even if I never saw a project logging messages like that in many years The main issue here is the fact that we log non required messages as Messages should be logged as by examples what k8s API server reports:
Ideally when there is an the stack trace should be logged on several lines |
The logging format is fine for a Kubernetes controller, but idpbuilder is supposed to be a CLI tool. So we should remove irrelevant fields like Charles said. I think we should have these for debug messages though. |
it could be that we modify this in two ways:
multiline massively helps with readability though, so I suggest we keep it when color outputs are printed. |
I'm not really a fun of multi line logging tbh, but I think it's fine if used with the color option because it's meant for humans. We should definitely get rid of controller name, kind, and reconcile id for info level. |
fixes #395
This breaks the log lines into multi-lines for ease of readability.
It does it for both when the color option is enabled and not. We can ideally modify it to be enabled only when the color option is enabled.
cc @cmoulliard