fix: rename gitea secret for better description

[rattboi]

partially fixes #216

This only covers the gitea secret renaming, as apparently the argocd one is generated by argo on installation, and is hardcoded to argocd-initial-admin-secret.

See here: https://github.com/argoproj/argo-cd/blob/0f11dfb5961361807962aafc68b11426b8a47490/cmd/argocd/commands/admin/initial_password.go#L16

There's some world where we could replicate the secret into one with a name we like better, but that sounds like a recipe for confusion.

[cmoulliard]

Approved !

[nabuskey]

LGTM. If you could fix up my mistake I'd appreciate it :)

[elamaran11]

@rattboi @nabuskey Im getting below error while pull the latest code and deploy. Im not sure if this is related to this PR.

❯ k describe externalsecrets.external-secrets.io gitea-credentials -n backstage
Name:         gitea-credentials
Namespace:    backstage
Labels:       <none>
Annotations:  argocd.argoproj.io/tracking-id: backstage:external-secrets.io/ExternalSecret:backstage/gitea-credentials
API Version:  external-secrets.io/v1beta1
Kind:         ExternalSecret
Metadata:
  Creation Timestamp:  2024-04-26T18:55:27Z
  Generation:          1
  Resource Version:    3292
  UID:                 cc875094-b758-42ec-b20a-07265d00bd8e
Spec:
  Data:
    Remote Ref:
      Conversion Strategy:  Default
      Decoding Strategy:    None
      Key:                  gitea-credential
      Metadata Policy:      None
      Property:             username
    Secret Key:             GITEA_USERNAME
    Remote Ref:
      Conversion Strategy:  Default
      Decoding Strategy:    None
      Key:                  gitea-credential
      Metadata Policy:      None
      Property:             password
    Secret Key:             GITEA_PASSWORD
  Refresh Interval:         0
  Secret Store Ref:
    Kind:  ClusterSecretStore
    Name:  gitea
  Target:
    Creation Policy:  Owner
    Deletion Policy:  Retain
    Name:             gitea-credentials
Status:
  Conditions:
    Last Transition Time:  2024-04-26T18:55:27Z
    Message:               could not get secret data from provider
    Reason:                SecretSyncedError
    Status:                False
    Type:                  Ready
Events:
  Type     Reason        Age                 From              Message
  ----     ------        ----                ----              -------
  Warning  UpdateFailed  40s (x14 over 85s)  external-secrets  error retrieving secret at .data[0], key: gitea-credential, err: secrets "gitea-credential" not found

[rattboi]

are you using a rebuilt idpbuilder binary, or just the ref-implementation package against the old binary? The secret is provisioned by idpbuilder itself, and I would say this is a breaking change.

[nabuskey]

Yea just need to update the secret name in the example.

[elamaran11]

I think you both are right. I didnt rebuild the binary, let me try that out! Thanks!

[elamaran11]

@nabuskey Could we have a patch release for this breaking change?

[nimakaviani]

+1 on a micro release if the latest binary doesnt go with the ref implementation.

Also another good reason to separate the examples repo, so we can cut versions both on the binary and the examples.

[nabuskey]

Yeah we really need to decouple the two and pin to a version