Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print correct argocd url after cluster bringup #223

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

rattboi
Copy link
Contributor

@rattboi rattboi commented Apr 26, 2024

Also, use idpbuilder to fetch argo admin secret for initial login

Fixes #213

Also, use `idpbuilder` to fetch argo admin secret for initial login

Signed-off-by: Bradon Kanyid (rattboi) <[email protected]>
@rattboi rattboi force-pushed the rattboi/fix-argo-url-on-create branch from f39d1d3 to 807cb11 Compare April 26, 2024 01:16
@cmoulliard
Copy link
Contributor

Approved !

Copy link
Collaborator

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just a minor comment. Otherwise looks good.

pkg/cmd/create/root.go Outdated Show resolved Hide resolved
Signed-off-by: Bradon Kanyid (rattboi) <[email protected]>
@nabuskey nabuskey merged commit d5802b6 into cnoe-io:main Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Help text output after cli create command with --use-path-routing gives wrong argocd url
3 participants