Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ReadMe documentation for Backstage Terraform Integrations #220

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

elamaran11
Copy link
Contributor

Updating ReadMe documentation for Backstage Terraform Integrations to support package integrations with Backstage Terraform Integrations repo.

Copy link
Collaborator

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not put experimental integration information unrelated to idpbuilder's main functionalities in the main readme. I would rather put these in the example readme instead.

@nimakaviani
Copy link
Contributor

+1 to what @nabuskey said.

The idea with integrations is for users to go to the repos for the integrations and extensions to decide and follow next steps

@elamaran11
Copy link
Contributor Author

@nimakaviani @nabuskey Please check my updates based on your comments. I agree to your recommendation, we dont need to update the base readMe.

elamaran11 and others added 4 commits April 25, 2024 16:19
Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani nimakaviani merged commit f883470 into cnoe-io:main Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants