use git providers #205
use git providers #205
Conversation
|
Amazing, thanks! will review later today but very excited about this. cc @greghaynes |
| Name: v1alpha1.GitProviderGitea, | ||
| GitURL: resource.Spec.GitServerURL, | ||
| InternalGitURL: resource.Spec.InternalGitServeURL, | ||
| OrganizationName: v1alpha1.GiteaAdminUserName, |
There was a problem hiding this comment.
this is a bit confusing here that we have an variable GiteaAdminUserName as the OrganizationName we probably can have a better variable name or make some clarification here
There was a problem hiding this comment.
This is how it's set up right now and this will be changed in the future. The primary purpose of this PR is to keep the current default behaviour but allow for modifications in the future.
| GitURL: resource.Status.Gitea.ExternalURL, | ||
| InternalGitURL: resource.Status.Gitea.InternalURL, | ||
| Provider: v1alpha1.Provider{ | ||
| Name: v1alpha1.GitProviderGitea, |
There was a problem hiding this comment.
Given that we are hard-coding it to Gitea, what would be the step for users to choose GitHub instead? Are the users expecetd to add a separate provider to support Github in a way that it co-exists with Gitea? or is there a way to choose alternatives?
There was a problem hiding this comment.
No way to choose an alternative with this PR. To do it, we need to update the CLI and other controllers. Doing it in all one PR will result in a massive PR. Trying to keep a PR small.
Signed-off-by: Manabu McCloskey <[email protected]>
Signed-off-by: Manabu McCloskey <[email protected]>
Signed-off-by: Manabu McCloskey <[email protected]>
With this PR, I am trying to lay ground work for enabling integrations with GitHub.
This doesn't change our current behaviours at all. It still uses Gitea as the git provider.