Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds the argo workflow to run terraform templates #203

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

nimakaviani
Copy link
Contributor

creates a new example runner for launching terraform templates from within the idpBuilder

@nimakaviani nimakaviani requested a review from nabuskey April 22, 2024 18:59
project: default
source:
repoURL: https://github.com/cnoe-io/backstage-terraform-integrations
targetRevision: main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to pin to a version?

Copy link
Contributor Author

@nimakaviani nimakaviani Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call. I'd say at a later point in time. Right now this whole line of work is experimental and for demo purposes.

@nimakaviani
Copy link
Contributor Author

cc @elamaran11

Copy link
Collaborator

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a readme and let people know it's still under construction

@nimakaviani
Copy link
Contributor Author

sounds good, will make the change.

@nimakaviani nimakaviani force-pushed the terraform-integration branch from cd3ec50 to 94bd0fc Compare April 24, 2024 17:43
Signed-off-by: Nima Kaviani <[email protected]>
@nimakaviani nimakaviani force-pushed the terraform-integration branch from 94bd0fc to 10c55d2 Compare April 24, 2024 17:46
Copy link
Collaborator

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabuskey nabuskey merged commit d08aed5 into main Apr 24, 2024
2 checks passed
@nabuskey nabuskey deleted the terraform-integration branch April 24, 2024 19:30
@csantanapr
Copy link
Contributor

@nimakaviani Is this missing the backstage templates?

@elamaran11
Copy link
Contributor

@csantanapr Backstage templates are in this repo and should be added to the backstage-config and documentation is all in readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants