move go.mod to project root #114
Conversation
mmorel-35
force-pushed
the
issue-104
branch
5 times, most recently
from
4410e8f to
6553c1d
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
There was a problem hiding this comment.
Will it be possible to keep all those changes in the "go/" directory?
The reason is, I think it would be best to keep these files separated from the proto sources.
I'm not sure what causes these, but would like all the "go" related stuff that don't use bazel to be in their own directory.
There was a problem hiding this comment.
Not with the actual capabilities of bazel_gazelle, see https://dev.azure.com/cncf/xds/_build/results?buildId=182921&view=logs&j=6614165d-8168-5766-9db6-f35f537f8e36&t=357c2333-0bbe-5588-5320-1bd2a4987c75&l=52, the name of the file is checked said here
There was a problem hiding this comment.
I think this pattern should be discouraged.
IMHO having the go files so it is easier to use them is great, but it should be limited to a specific sub-dir that is different than where the "source files" (protos) are.
This moves go.mod to the root directory of the project and the go code follows this change to.
Closes #104