Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update landscape.yml with calendar link as a test for bpfman PCC calendar link #4254

Merged
merged 5 commits into from
Mar 7, 2025

Conversation

riaankleinhans
Copy link
Contributor

@tegioz & @cynthia-sg I want to test and see if this work to get the PCC calendars links on the project's landscape card.
https://www.cncf.io/projects/bpfman/

Copy link

github-actions bot commented Mar 4, 2025

You can preview your changes by visiting this link.

Note

This feature is still experimental and may not work as expected in some cases. Please report any issues you find!

@tegioz
Copy link
Contributor

tegioz commented Mar 4, 2025

Hi @riaankleinhans 👋

That field won't be used by the landscape (it will be ignored actually). Not sure if the CNCF website is picking it up from the landscape.yml file somehow, but we're not exporting it from the landscape API either.

There is a field named other_links that you can use to display this link in the landscape if you'd like (more details about how it works here). But the link you shared was a card from the CNCF website, not the landscape. So you may need something else to make it appear there.

/cc @cjyabraham

Signed-off-by: Riaan Kleinhans <[email protected]>
@riaankleinhans
Copy link
Contributor Author

Thank you @tegioz, I change the link to other_links
Will follow up with @cjyabraham about the project cards.

@tegioz
Copy link
Contributor

tegioz commented Mar 4, 2025

No worries!

Please take a look at the link I shared about how that field works, as the format used is not correct (that's why the landscape.yml validate check isn't passing).

@riaankleinhans
Copy link
Contributor Author

The landscape build do not like my zoom link under other_links

Signed-off-by: Riaan Kleinhans <[email protected]>
Signed-off-by: Riaan Kleinhans <[email protected]>
Signed-off-by: Riaan Kleinhans <[email protected]>
@cjyabraham
Copy link
Contributor

The CNCF project pages aren't set up to import an arbitrary list of other_links for display on the project pages. If there's a particular one you'd like to have support for, perhaps you could write an issue here and we can consider it?

Copy link
Contributor

@cynthia-sg cynthia-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@castrojo castrojo added this pull request to the merge queue Mar 7, 2025
Merged via the queue into cncf:master with commit 911a2ec Mar 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants