Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z-210 ANCW: Caustic Armor for research #6592

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

TheManWithNoHands
Copy link

@TheManWithNoHands TheManWithNoHands commented Jun 29, 2024

About the pull request

Adds a new set of armor to the game.
The Z-210 ANCW. An Armor set that research can print for a step price.
It provides heavy Bio protection, a bit better bomb protection and heat protection, but in turn, it is much less effective against bullets and reacts harsher to electric shocks.

It has even an actual place in the lore, being that its based on the Z-110 ANCW. An anti xenomprh armor that uses gel to turn acid into basicly water. The chest pice contains its lore blurp.
https://avp.fandom.com/wiki/Z-110_Acid_Neutralizing_Combat_Wardrobe

Prices are WIP and definitly need a second opion.

Explain why it's good for the game

Its another thing research can buy using their printer.
The bioprinter is currently our fairest pointshop we have, being the only one that doesnt gain points by being AFK. And we have one shop where you can be AFK to earn metal, wich is one of the strongest things in the game.

The printer already has a lot of great options people can chose to spend their points on. Expanding the list of avalibel things to buy from it, gives the printer and research much more varity. So they hopefully dont do the same every round.
There is already the thing that a lot of researchers only use the printer to make more points for stims.
So giving the printer more atractive options would help reduce the over reliance on stims.

Testing Photographs and Procedure

https://imgur.com/a/TpXl0oc

Changelog

🆑 TheManWithNoHands

add: Added Caustic Armor
imageadd: added icons for new armor, helmet, gloves, boots, uniform and kit

/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Jun 29, 2024
@TheManWithNoHands TheManWithNoHands changed the title Z-210-C ANCW Armor for research Bioprinter Z-210-C ANCW Armor for research Jun 29, 2024
@TheManWithNoHands TheManWithNoHands changed the title Z-210-C ANCW Armor for research Z-210-C ANCW: Caustic Armor for research Jun 29, 2024
code/datums/research_upgrade_datum.dm Outdated Show resolved Hide resolved
code/modules/clothing/head/helmet.dm Outdated Show resolved Hide resolved
code/modules/clothing/head/helmet.dm Outdated Show resolved Hide resolved
code/modules/clothing/head/helmet.dm Outdated Show resolved Hide resolved
@TheManWithNoHands TheManWithNoHands changed the title Z-210-C ANCW: Caustic Armor for research Z-210 ANCW: Caustic Armor for research Jun 30, 2024
Comment on lines 1017 to 1018
var/gas_filter_strength = 1 //For gas mask filters
var/list/filtered_gases = list("phoron", "sleeping_agent", "carbon_dioxide")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't seem to ever use these?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh rigth, went a bit braindead for a moment there. Copyd that from our gasmasks. Let me look for the code to make this do something.

Ok, im back. And fun thing, thats not the only thing that doesnt do anything.
var/gas_transfer_coefficient
var/permeability_coefficient
They are both on a ton of headgear and masks, but i could not find them even mentioned other then as an item var.
Non of those two things seem to do anything. They are just vars that seem to be left over.

code/modules/clothing/suits/marine_armor/_marine_armor.dm Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants