Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faction datum rework & statistic battle rating admin and adming game balance info stuff #6589

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blackcrystall
Copy link
Contributor

@blackcrystall blackcrystall commented Jun 28, 2024

About the pull request

(attempt to port it over №2, after 2 years)

For maintainers: contact me on forum or discord (discord nick as in changelog CL), for addition approving (big features and etc, like statistic, I remember my small talk with Nanu about it long time ago, so yea) or discussions about all stuff in Task section (same, to make it as yall be like to see it), all this code already done, I'm just porting it from my other project and finishing some things (like Actions between factions, faction tasks and some minor contemt for HVH), for me it's fine if something will be denied.

Brand new datums, with module system.
Will be added later more info

WIP (mostly messing with porting stuff, going thru entire game code to be dmed with: Bro, no denied rework)

Tasks

  • [🛠️] Make factions as fully datums handling every mess around it (port)
  • [🛠️] Faction task, or How To Win, some progress for other gamemodes like HVH (port & finishing & polishing) (disabled, when I reach dev lead and etc, we talk about it)
  • [🛠️] Actions between factions (port & finishing) (disabled, same as prev one)
  • [🛠️] Auto Balancer (port & polishing) (module for admin statistic, ANOTHER PR of PORTING STUFF)
  • [🛠️] TGUI for faction interactions, admin faction information stuff and controlling funny clickable game enders buttons, statistic and balancing/relative skill rating/some calculations about players
  • [🛠️] Do all my TODO: marks (:clueles_face:, lazy)

Changelog

🆑 blackcrystalic
add: Brand new factions functional
ui: new TGUI for faction interactions and misc stuff with statistic/rationg
code: Work around faction datums
refactor: Factrions backend
admin: messing with admin stuff, statistic and faction information, balance victory, players relative rating (skill)
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jun 28, 2024
@blackcrystall blackcrystall changed the title Faction datum rework & statistic battle rating admin and balancing stuff Faction datum rework & statistic battle rating admin and adming game balance info stuff Jun 28, 2024
@github-actions github-actions bot added UI deletes nanoui/html Code Improvement Make the code longer Refactor Make the code harder to read Admin Make things harder for admins labels Jun 28, 2024
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unreviewably large. Atomize it or talk to the maintainers about getting a project branch for this

@Zonespace27 Zonespace27 added the Do Not Merge If you merge this PR, I will annihilate you label Jun 29, 2024
@vero5123

This comment has been minimized.

@blackcrystall
Copy link
Contributor Author

This is unreviewably large. Atomize it or talk to the maintainers about getting a project branch for this

Yeah, I have troubles with reaching them again, after long break... So, after unban in discord, or I can chat on forum with maintainers/heads

Anyway, I'm not running right now this to fast finish & merge, soooo yea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Make things harder for admins Code Improvement Make the code longer Do Not Merge If you merge this PR, I will annihilate you Feature Feature coder badge Refactor Make the code harder to read UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants