Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Yautja Weapon Gimmicks, Round Two #5392

Closed

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Jan 6, 2024

About the pull request

Work on giving Yautja Weapons gimmicks again.

Explain why it's good for the game

Work in Progress. Allows Yautja weapons to have some flair beyond being variably effective sticks.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Yautja weapons now collect blood 'charges' for using their abilites.
add: Combistick now requires two hits to throw instead of one, but can store up to two throws.
add: Scythe now can perform an AOE attack similar to Ravager Eviscerate, after five successful hits.
add: Chainwhip can now bind a target with chains, tying them to within three tiles of the Yautja.
balance: Reduced the probability for combistick blocking from 2/3 hits to 1/3
balance: Repaired the 15% hardcap on yautja mask knock chance.
code: Changed damage variables on smartdisc to use existing defines rather than raw numbers.
/:cl:

To-do:

  • Add binding to chainwhip
  • Make certain abilities decay over time if not used, to prevent hoarding attacks on lesser foes (such as with the chainwhip) for more dangerous opponents.
  • Consider abilities for the sword.

@realforest2001 realforest2001 added this to the Yautja Changes milestone Jan 6, 2024
@github-actions github-actions bot added Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Jan 6, 2024
@RenaRenaRe
Copy link
Contributor

RenaRenaRe commented Jan 6, 2024

Just so you know the block chance you changed only applies to pounces, since that seems to be the only time "combistick" is set to true. For xeno slashes it uses:
if(I.IsShield() && !istype(I, /obj/item/weapon/shield) && (prob(50 - round(damage / 3))))

Keep in mind "damage" is always sent as 0 (at least for xeno slashes) so currently block chance for slashes is 50%, this PR changes specifically changes pounce block chance from 2/3 to 1/3.
Just figured I'd point this out since the changelog says you changed the % of "hits" that it blocks which isn't really true.

@realforest2001 realforest2001 marked this pull request as draft January 6, 2024 19:22
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jan 7, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jan 7, 2024
cm13-github added a commit that referenced this pull request May 8, 2024
@github-actions github-actions bot added the Code Improvement Make the code longer label May 8, 2024
cm13-github added a commit that referenced this pull request May 8, 2024
cm13-github added a commit that referenced this pull request May 8, 2024
cm13-github added a commit that referenced this pull request May 9, 2024
@realforest2001 realforest2001 changed the title Yautja Weapon Gimmicks, Round Two (WIP) Yautja Weapon Gimmicks, Round Two May 10, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label May 14, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label May 20, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label May 28, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@harryob harryob removed the Stale Exempt PR can't go stale label Jul 9, 2024
@harryob
Copy link
Member

harryob commented Jul 9, 2024

re-open when this isn't wip and no conflicts

@harryob harryob closed this Jul 9, 2024
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Sep 12, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants