Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SG adjustments, power & ammo #535

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

BonniePandora
Copy link
Contributor

@BonniePandora BonniePandora commented Nov 4, 2024

About the pull request

Adds a new ammunition type for smartgunners to utilise; Impact Detonating. Slightly less damaging than the standard round, with less armour-penetration, but it inficts a slowdown on targets hit. Useful for crowd control, especially when up against multiple crusher-type enemies.
Power-usage per shot is increased across the board for the ammo types, with AP having a slightly higher per-shot usage and Imp-Det being a fair bit higher.

Big props to Drathek for the help throughout this.

Explain why it's good for the game

More features to engage the brains of SG players should they chose to use this stuff. Also balances the gun system a bit by making them more likely to run outa power during longer operations, encouraging them to bring their spare or engage in RP with the other for their spare.

Testing Photographs and Procedure

Tested locally repeatedly, compiles fine and functions as intended

Changelog

🆑
add: New smartgun ammo type; Impact Detonating
balance: smartguns now use more power depending on the ammo type selected.
imageadd: Icon for the ammo mode when toggled to
/:cl:

Doubleumc
Doubleumc previously approved these changes Nov 11, 2024
Copy link
Contributor

@Doubleumc Doubleumc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code good!

@Doubleumc Doubleumc added do not merge needs tested testmerge this to see what breaks labels Nov 11, 2024
code/datums/ammo/ammo.dm Outdated Show resolved Hide resolved
Doubleumc
Doubleumc previously approved these changes Nov 25, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Doubleumc
Doubleumc previously approved these changes Dec 27, 2024
Copy link

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants