Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime cxxmodules aarch64 #215

Open
wants to merge 12 commits into
base: cms/master/2c8521e17d
Choose a base branch
from

Conversation

smuzaffar
Copy link

No description provided.

guitargeek and others added 10 commits December 9, 2024 11:10
The PROOF interface in RooFit/RooStats didn't work anymore for a long
time, so nobody will be suprised if this is removed.
strlen cannot be a constexpr in all platforms otherwise.
1. Draw frame histogram and object only once
2. Use TH2 as frame histogram to properly handle zooming
3. In Paint method paint only TFileDrawMap itself
4. Keep generated branch colors to make reproducible painting
5. Make non-persistent TFile pointer, otherwise fails when reading
5.
Since scikit version 1.4 the SAMME.R algorithm is deprecated and it has been removed since version 1.6.
Change default to use SAMME
See https://scikit-learn.org/1.5/modules/generated/sklearn.ensemble.AdaBoostClassifier.html
Let create meningful header for context menu
While normal events are not provided by web canvas,
try at least use last click event to identify which part
of file is clicked.

In all methods use TString for strings manipulation
1. Experimental scaling functionality, generating images
    with more pixels as on display
2.  Provide better interactivity with TWebPainting
@cmsbuild
Copy link

A new Pull Request was created by @smuzaffar for branch cms/master/2c8521e17d.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link

cmsbuild commented Dec 11, 2024

cms-bot internal usage

@smuzaffar
Copy link
Author

please test for CMSSW_15_0_ROOT6_X/el8_aarch64_gcc12

In case of weak definitions, JITLink might merge symbols because we
currently add all llvm::Module's into a single JITDylib. For merges
that late in the pipeline, we also have to prevent optimizations that
take advantage of "localness" to avoid out-of-range relocations for
example on AArch64.
It was disabled in commit a67863d ("Disable modules on aarch64 due
to ODR violation") in 2019. I cannot reproduce these problems on
lxplus-arm, so try to turn it back on.
@cmsbuild
Copy link

-1

Failed Tests: AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6790d/43375/summary.html
COMMIT: 3c3c8c1
CMSSW: CMSSW_15_0_ROOT6_X_2024-12-10-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/root/215/43375/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6790d/43375/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6790d/43375/git-merge-result

AddOn Tests

  • unknown
AddOnTest might have timed out: FAILED -  secs

@cmsbuild
Copy link

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6790d/43375/summary.html
COMMIT: 3c3c8c1
CMSSW: CMSSW_15_0_ROOT6_X_2024-12-10-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/root/215/43375/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6790d/43375/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6790d/43375/git-merge-result

@cmsbuild
Copy link

Pull request #215 was updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants