Skip to content

Conversation

@sbaldu
Copy link
Contributor

@sbaldu sbaldu commented Jul 22, 2025

PR description:

This PR implements helper functions and type traits to handle the behaviours required by the different column types without the need to use boost conditions, thus reducing the use of macros and improving readability.
There are some helper functions that are marked as TODOs, as they are waiting for further developments in the backend of the SoA Layout class.

PR validation:

All the tests still pass, as the behaviour is unchanged.

FYI @leobeltra @fwyzard @felicepantaleo

@cmsbuild cmsbuild added this to the CMSSW_15_1_X milestone Jul 22, 2025
@cmsbuild
Copy link
Contributor

This PR contains many commits (221 >= 150) and will not be processed. Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar, to re-enable processing of this PR, you can write +commit-count in a comment. Thanks.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 22, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48605/45573

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sbaldu for master.

It involves the following packages:

  • Configuration/ProcessModifiers (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • DataFormats/SoATemplate (heterogeneous)
  • SimCalorimetry/EcalSimProducers (simulation)
  • SimCalorimetry/HcalSimProducers (simulation)
  • SimGeneral/MixingModule (simulation)
  • SimGeneral/TrackingAnalysis (simulation)
  • SimMuon/CSCDigitizer (simulation)
  • SimMuon/DTDigitizer (simulation)
  • SimMuon/GEMDigitizer (simulation, upgrade)
  • SimMuon/RPCDigitizer (simulation)
  • SimTracker/SiPixelDigitizer (simulation)
  • SimTracker/SiStripDigitizer (simulation)

@AdrianoDee, @Moanwar, @antoniovilela, @civanch, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @fwyzard, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@24LopezR, @CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Martin-Grunewald, @ReyerBand, @VinInn, @VourMa, @abbiendi, @abdoulline, @argiro, @battibass, @bsunanda, @cericeci, @dgulhan, @dkotlins, @echabert, @fabiocos, @ferencek, @fsimone91, @giovanni-mocellin, @jhgoh, @jshlee, @llunerti, @makortel, @mariadalfonso, @martinamalberti, @missirol, @mmusich, @mroguljic, @mtosi, @prolay, @ptcox, @rchatter, @robervalwalsh, @rovere, @sameasy, @slomeo, @thomreis, @threus, @trocino, @tsusa, @tvami, @wang0jin, @watson-ij this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

@sbaldu it looks like you started from the special branch CMSSW_15_1_FASTPU_X. This branch is specifically for development of a new pileup mixing approach. It is not ready to be merged into master yet. Please rebase your branch onto the standard branch CMSSW_15_1_X.

@kpedro88
Copy link
Contributor

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @kpedro88
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Jul 22, 2025
@sbaldu
Copy link
Contributor Author

sbaldu commented Jul 22, 2025

@sbaldu it looks like you started from the special branch CMSSW_15_1_FASTPU_X. This branch is specifically for development of a new pileup mixing approach. It is not ready to be merged into master yet. Please rebase your branch onto the standard branch CMSSW_15_1_X.

Ok, I'm closing and opening from the correct release.

@sbaldu sbaldu closed this Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants