-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Implement template helper functions to reduce macro depencencies in SoA backend #48605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement template helper functions to reduce macro depencencies in SoA backend #48605
Conversation
|
This PR contains many commits (221 >= 150) and will not be processed. Please ensure you have selected the correct target branch and consider squashing unnecessary commits. |
…ts through the MixingModule interface to be used during the Digitization step in different sub-systems
…ent of remaining couts
…k is set to True for FastPU with FastSimPU modifier in python/mix_probFunction_25ns_PoissonOOTPU_cfi.py
…l from FullSim and PU frm FastSim
Use template functions instead of macro `SWITCH_ON_TYPE`s
c0d0544 to
e3afd46
Compare
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48605/45573
|
|
A new Pull Request was created by @sbaldu for master. It involves the following packages:
@AdrianoDee, @Moanwar, @antoniovilela, @civanch, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @fwyzard, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@sbaldu it looks like you started from the special branch |
|
hold |
|
Pull request has been put on hold by @kpedro88 |
Ok, I'm closing and opening from the correct release. |
PR description:
This PR implements helper functions and type traits to handle the behaviours required by the different column types without the need to use boost conditions, thus reducing the use of macros and improving readability.
There are some helper functions that are marked as TODOs, as they are waiting for further developments in the backend of the SoA Layout class.
PR validation:
All the tests still pass, as the behaviour is unchanged.
FYI @leobeltra @fwyzard @felicepantaleo