Pepr cmssw 11 3 0 pre2 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Remove the possibility of changing the grid size used by the cms::cudacompat layer, and make it a constant equal to {1, 1, 1}. This avoids a thread-related problem caused by TBB using worker threads where the grid size had not been initialised. The kernel for pixel clustering need to be rewritten to support a one-dimensional grid to run on the CPU. Currently they are only used on the GPU in the Patatrack workflows, but they are exercised on the CPU by the gpuClustering_t tests; those tests have been commented out until the kernels can be updated.
Address the pixel local reconstruction review comments. General clean up of the pixel local reconstruction code: - remove commented out and obsolete code and data members - use named constants more consistently - update variable names to follow the coding rules and for better consistency - use member initializer lists in the constructors - allow `if constexpr` in CUDA code - use `std::size` instead of hardcoding the array size - convert iterator-based loops to range-based loops - replace `cout` and `printf` with `LogDebug` or `LogWarning` - use put tokens - reorganise the auto-generated cfi files and use them more consistently - adjust code after rearranging an `#ifdef GPU_DEBUG` block - apply code formatting - other minor changes Improve comments: - improve comments and remove obsolete ones - clarify comments and types regarding `HostProduct` - update comments about `GPU_SMALL_EVENTS` being kept for testing purposes - add notes about the original cpu code Reuse some more common code: - move common pixel cluster code to `PixelClusterizerBase` - extend the `SiPixelCluster` constructor Rename classes and modules for better consistency: - remove the `TrackingRecHit2DCUDA.h` and `gpuClusteringConstants.h` forwarding headers - rename `PixelRecHits` to `PixelRecHitGPUKernel` - rename SiPixelRecHitFromSOA to SiPixelRecHitFromCUDA - rename `siPixelClustersCUDAPreSplitting` to `siPixelClustersPreSplittingCUDA` - rename `siPixelRecHitsCUDAPreSplitting` to `siPixelRecHitsPreSplittingCUDA` - rename `siPixelRecHitsLegacyPreSplitting` to `siPixelRecHitsPreSplittingLegacy` - rename `siPixelRecHitHostSoA` to `siPixelRecHitSoAFromLegacy` Re-apply changes from cms-sw#29805 that were lost in the Patatrack branch.
Address the pixel local reconstruction review comments. General clean up of the pixel local reconstruction code: - update comments; - update data members for better consistency; - remove unimplemented method.
Address the pixel local reconstruction review comments: - update method names according to the coding rules.
…eTauolaInterface Added missing package dependency needed for UBSAN in GeneratorInterface/TauolaInterface
…wardDetectors Added missing package dependency needed for UBSAN in FastSimulation/ForwardDetectors
Clean some more BuildFiles
Address the pixel local reconstruction review comments:
- remove obsolete comments;
- consistently use named constants;
- rename data members and methods to be more descriptive;
- rename local variables according to the coding rules and for
consistency with cms-sw#32591;
- update transient dictionaries to match data types.
Run3-gex45 Use of ESGetToken in EcalAlgo examples
MLPF: first integration of EDProducer and training code
Run4-hgx284x Modify the conversion code to make titles for HGCal
Some modernization of plugins in EgammaIsolationAlgos
The UBSAN build reported that an index of -2 was being used as an index into the arrays.
Run4-hgx284 Algorithm to make partial silicon modules
Revert cms-sw#25298; memory leak fix for HepPDT::HeavyIonUnknownID
Update 2021 relval matrix for IB test
…ion_7_N_ecal_local_reco Patatrack integration - ECAL local reconstruction (7/N)
fix in PixelTrackBuilder and MuonIdProducer to get debug build work for static ana
…_X_2021-01-15-1100 finecalo patches v1 (rebased)
Avoid writing off beginning of arrays in RPCMonitorClient
Use EDPutToken in ReducedEGProducer and modernize GEDPhotonCoreProducer
Fix a couple of sparse issues in reco pointed out by the static analyzer
…SSW_11_3_0_pre2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: