Quest: Fixed the lack of quest's reputation spillover data #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have added per quest reputation spillover data, and changed the code to utilize that data. Current changes are made to perfectly mimic previous behavior. The purpose of this commit is only to create basis for future changes of quest's reputation spillover.
|
Please name some sources for reference that this is needed. |
JJBcku
force-pushed
the
ReputationSpilloverFix
branch
from
6b13f68
to
0c9be8e
Compare
|
Here are a few of my sources: Seems to me like all discussion of quest's reputation gain from classic wow agree that some quest do not reward spillover reputation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code apply reputation spillover to all sources of reputation while quest reputation spillover is supposed to be determined separately for each quest. To fix this behavior I have added the ReputationSpillover column to quest_template and changed the code to utilize this information.
Current changes are made to perfectly mimic previous behavior. The purpose of this commit is only to create basis for future changes of quest's reputation spillover.