Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move multicluster crds to the templates crds directory #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanielXLee
Copy link
Contributor

Signed-off-by: DanielXLee [email protected]

fixes: #39

@dixudx
Copy link
Member

dixudx commented Dec 1, 2022

@DanielXLee I am not suggesting moving mcs crds into templates folder for below two reasons.

  1. These mcs crds are not only used by clusternet-hub, but also for clusternet-agent. If we are putting them into template folder, we can not install clusternet-hub and clusternet-agent in a same cluster. Helm will complain the installation error. You have a try on this.
  2. These mcs crds are mostly static and not updated with Clusternet. Helm will only help ensure CRDs in folder ./crds/ are installed. And helm will skip installing them when they are already installed.

We do move these crds into different folders back and forth. I think for non Clusternet crds, putting them into Helm default ./crds folder is not a bad choice.

cc @lmxia

@DanielXLee
Copy link
Contributor Author

I didn't consider the case where the hub and agent are in the same cluster, it's more important.
If cannot install these crds when upgrading, I need manually install multicluster crds in these clusters, we have about 100 hub clusters. 😦

@dixudx
Copy link
Member

dixudx commented Dec 1, 2022

If cannot install these crds when upgrading

These mcs crds are not changed. I did not get the upgrading issue here. @DanielXLee Could you elaborate what happens during the upgrading? Thanks.

I need manually install multicluster crds in these clusters, we have about 100 hub clusters.

Clusternet does have the capability to distribute resources to multiple clusters. These resources can be CRDs. This is not a blocking issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

muitilcluster crd don't installed for the upgrade case
2 participants