Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on PHP 8.3 and update test suite #21

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Run tests on PHP 8.3 and update test suite #21

merged 1 commit into from
Feb 3, 2024

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Jan 17, 2024

This pull request builds on top of #13 and #9.

References: reactphp/socket#300, clue/reactphp-zenity#63, clue/reactphp-csv#33 and others.

SimonFrings
SimonFrings approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@SimonFrings SimonFrings added this to the v0.3.0 milestone Jan 22, 2024
@SimonFrings SimonFrings requested a review from clue February 2, 2024 14:42
clue
clue approved these changes Feb 3, 2024
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit 18475df into clue:master Feb 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonFrings SimonFrings SimonFrings approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yadaiio @clue @SimonFrings