Fix utils.py for preventing KeyError at self.dict[char] #403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And improving training quality.
It's weird to get the character from opt.character and get the train's GroundTruth directly without any filtering. You should check it at least once.
Can occur KeyError
So, you can think that if you change
'text = [self.dict[char] for char in text]'
into 'text = [self.dict[char] for char in text if char in self.dict]', problem will solve
but there is a possibility of mislearning.
Should drop all data including that char. because it could make train worse.
So I change the code like that