This repository has been archived by the owner on Nov 24, 2024. It is now read-only.
Release for 0.7.0 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe, last CDDA version bump has already turned this on by default. Yay!
|
I could send a patch to Tankmod-Revived mod to fix the error and unblock this PR for the updated CDDA version (assuming it's just by removing this single-line or someone else could freely do it as I'm not familiar with the codebase. I might need to drop the Arcana mod temporarily as it's quite a large mod in terms of features (meaning more time required to review and test) to move this PR forward. |
There's a commit in the CDDA upstream that breaks the pinned Tank_Revived mod, which is no bueno for this PR. See chaosvolt/cdda-tankmod-revived-mod#35 We downgraded CDDA version just one release away from that one and things seems to work ok (no major crashes) as far as I'm concerned.
|
Decided not to rebase/squash the commits. The changes seem fairly clear. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDDAto2024-11-03-0625.BumpArcanamod (currently blocked by item group id guns_pistol_improvised is unknown chaosvolt/cdda-arcana-mod#447)Tankmod-Revived(currently blocked by invalid entry 'mon_zombie_bio_op' chaosvolt/cdda-tankmod-revived-mod#33)If you happen to read this and want to try this pull request right away, do the following:
nix run --refresh github:cloudyluna/cdda-custom-experimental/0.7.0#extras