Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kubernetes v1.16+ #29

Closed
wants to merge 1 commit into from

Conversation

robgmills
Copy link
Contributor

extensions/v1beta1 were marked deprecated in Kubernetes
v1.16
.

This enables support for newer versions of Kubernetes.

`extensions/v1beta1` were [marked deprecated in Kubernetes
v1.16](https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/).

This enables support for newer versions of Kubernetes.
@robgmills
Copy link
Contributor Author

Addresses #26

@weeco
Copy link
Member

weeco commented May 13, 2021

Hey @robgmills , looking at the PR I'd consider removing the ingress resource completely. But I wonder whether I'm missing something why you may want to use it?

@robgmills
Copy link
Contributor Author

I actually don't use the ingress resource. I'm not sure if others are using it or what they might be using it for. I might guess that someone who has a sufficiently complex Kubernetes environment might want to expose the kube-eagle /metrics endpoint from their cluster for some reason. Maybe they're collecting these metrics off-cluster for some reason?

I thought this change was the least disruptive for all users, whether or not they use the ingress resource, to continue using this chart on newer versions of Kubernetes.

If you'd prefer, I'd be happy to remove the ingress resource instead! After all, "the best diff is a red diff!"

@weeco
Copy link
Member

weeco commented May 16, 2021

Thanks for your feedback, I think we can remove the ingress and see if this bothers someone. Would be nice if you could remove it, thank you!

@robgmills
Copy link
Contributor Author

Superseded by #30. Closing.

@robgmills robgmills closed this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants