Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize(exit): server graceful shutdown logic to avoid EOF when idle connections receive new requests after being closed #1681

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

jayantxie
Copy link
Member

@jayantxie jayantxie commented Jan 21, 2025

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

optimize(exit): 优化server优雅退出逻辑以避免idle连接被关闭后收到新请求时的EOF问题

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@jayantxie jayantxie requested review from a team as code owners January 21, 2025 13:29
@jayantxie jayantxie force-pushed the optimize/graceful_shutdown branch from cb2c2c7 to c3ef1a4 Compare January 22, 2025 05:40
…on in idle state receives new requests after being closed
@jayantxie jayantxie force-pushed the optimize/graceful_shutdown branch from c3ef1a4 to 47594c0 Compare January 22, 2025 05:58
xiaost
xiaost previously approved these changes Jan 22, 2025
@jayantxie jayantxie changed the title optimize: the graceful shutdown logic to avoid errors when a connection in idle state receives new requests after being closed optimize: the graceful shutdown logic to avoid errors when idle connections receive new requests after being closed Jan 22, 2025
@jayantxie jayantxie changed the title optimize: the graceful shutdown logic to avoid errors when idle connections receive new requests after being closed optimize(exit): server graceful shutdown logic to avoid EOF when idle connections receive new requests after being closed Jan 22, 2025
ppzqh
ppzqh previously approved these changes Jan 22, 2025
@jayantxie jayantxie dismissed stale reviews from ppzqh and xiaost via 6932973 January 22, 2025 06:40
@jayantxie jayantxie force-pushed the optimize/graceful_shutdown branch from 6932973 to 91e914b Compare January 22, 2025 06:45
@jayantxie jayantxie force-pushed the optimize/graceful_shutdown branch from 91e914b to a251abd Compare January 22, 2025 06:53
@jayantxie jayantxie merged commit 4f3c3fc into cloudwego:develop Jan 22, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants