Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tool): remove redundant dependency for streamx generation code #1675

Merged

Conversation

DMwangnima
Copy link
Contributor

@DMwangnima DMwangnima commented Jan 14, 2025

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

fix(工具): 移除 streamx 生成代码中的冗余依赖

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
When generating streamx code with -thrift no_fmt, github.com/cloudwego/kitex/pkg/streamx is referenced twice:

"github.com/cloudwego/kitex/pkg/streamx"
"github.com/cloudwego/kitex/client/streamxclient/streamxcallopt"
"github.com/cloudwego/kitex/pkg/streamx"

Need to remove github.com/cloudwego/kitex/pkg/stream from the template since it is duplicated in the setImports.
zh(optional):
当使用-thrift no_fmt生成 streamx 代码时,github.com/cloudwego/kitex/pkg/streamx会被重复引用:

"github.com/cloudwego/kitex/pkg/streamx"
"github.com/cloudwego/kitex/client/streamxclient/streamxcallopt"
"github.com/cloudwego/kitex/pkg/streamx"

需要将模版中的github.com/cloudwego/kitex/pkg/stream移除,和 setImports 中添加的依赖重复了。

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@DMwangnima DMwangnima requested review from a team as code owners January 14, 2025 12:13
HeyJavaBean
HeyJavaBean previously approved these changes Jan 14, 2025
@DMwangnima DMwangnima merged commit cdfa084 into cloudwego:develop Jan 15, 2025
19 checks passed
@DMwangnima DMwangnima deleted the fix/streamx_remove_redundant_import branch January 15, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants