Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tool): use go.mod for -module #1674

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

xiaost
Copy link
Collaborator

@xiaost xiaost commented Jan 14, 2025

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:

  • Kitex tool uses go.mod as -module if a project has go.mod

zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@xiaost xiaost requested review from a team as code owners January 14, 2025 11:48
YangruiEmma
YangruiEmma previously approved these changes Jan 14, 2025
HeyJavaBean
HeyJavaBean previously approved these changes Jan 14, 2025
@xiaost xiaost dismissed stale reviews from HeyJavaBean and YangruiEmma via ca52e2e January 15, 2025 10:25
@xiaost xiaost changed the title feat(tool): use go.mod; deprecate GOPATH feat(tool): use go.mod for -module Jan 15, 2025
HeyJavaBean
HeyJavaBean previously approved these changes Jan 15, 2025
@xiaost xiaost merged commit a8d2a21 into cloudwego:develop Jan 17, 2025
19 checks passed
@xiaost xiaost deleted the tool-use-gomod branch January 17, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants