Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change chain default key to node_idx_parallel_idx style #34

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

kuhahalong
Copy link
Contributor

What type of PR is this?

feat: A new feature

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

change chain default key to "node_idx_parallel_idx" style, for example:
chain key is: node_idx => eg: node_0 => represent the first node of the chain (idx start from 0)
if has parallel: node_idx_parallel_idx => eg: node_0_parallel_1 => represent the first node of the chain, and is a parallel node, and the second node of the parallel
if has branch: node_idx_branch_key => eg: node_1_branch_customkey => represent the second node of the chain, and is a branch node, and the 'customkey' is the key of the branch

(Optional) More detailed description for this PR(en: English/zh: Chinese).

image

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2025

CLA assistant check
All committers have signed the CLA.

compose/chain.go Outdated Show resolved Hide resolved
compose/chain.go Outdated Show resolved Hide resolved
compose/graph_test.go Outdated Show resolved Hide resolved
Copy link

📊 Coverage Report:

File coverage threshold (20%) satisfied:	PASS
Package coverage threshold (30%) satisfied:	PASS
Total coverage threshold (75%) satisfied:	PASS
Total test coverage: 82.6% (2957/3578)

Copy link
Contributor

@BytePender BytePender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuhahalong kuhahalong merged commit 967e4b0 into main Jan 14, 2025
10 checks passed
@kuhahalong kuhahalong deleted the feat/chain_node_key branch January 14, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants