Feat/workflow #23
Open
Feat/workflow #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 152 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 148 | 4 | 0 | 0 |
Click to see the invalid file list
- compose/field_mapping.go
- compose/field_mapping_test.go
- compose/workflow.go
- compose/workflow_test.go
|
go-test-coverage report: |
shentongmartin
force-pushed
the
feat/workflow
branch
3 times, most recently
from
f0c5bf7 to
8cb48ef
Compare
|
|
shentongmartin
force-pushed
the
feat/workflow
branch
from
8cb48ef to
b030107
Compare
📊 Coverage Report: |
shentongmartin
force-pushed
the
feat/workflow
branch
from
b030107 to
e45266e
Compare
shentongmartin
force-pushed
the
feat/workflow
branch
from
e45266e to
1b0f73b
Compare
|
|
||
| edge2FieldMapFn map[string]map[string]fieldMapFn | ||
| edge2StreamFieldMapFn map[string]map[string]streamFieldMapFn | ||
| node2Mappings map[string][]*Mapping |
| } | ||
|
|
||
| type fieldMapFn func(any) (map[Mapping]any, error) | ||
| type streamFieldMapFn func(streamReader) streamReader |
There was a problem hiding this comment.
按上边的any->map[Mapping]any
流式的应该是streamReader -> StreamReader[map[Mapping]any] 吧？
| g.markRunTimeCheckEdge(startNode, endNode) | ||
| } | ||
| } else { | ||
| if startNodeOutputType == anyType || endNodeInputType == anyType { // input or output is any, can't do any check here, defer to request time |
There was a problem hiding this comment.
为啥in或out是any 要markRunTimeCheckEdge？ 有field mapping的时候不需要这个check吧
There was a problem hiding this comment.
而且除了any，interface应该也不能判断
| } | ||
|
|
||
| func checkAndExtractFieldType(field string, typ reflect.Type) (reflect.Type, error) { | ||
| if typ.Kind() == reflect.Ptr { |
Change-Id: I96c41c862bed7a57b13349dab1d26d221ff3a1ba
shentongmartin
force-pushed
the
feat/workflow
branch
from
f02f08d to
a6ed196
Compare
Change-Id: Ib459e12c3f05498f613d0fb97eefd49d036e68ee
shentongmartin
force-pushed
the
feat/workflow
branch
from
a6ed196 to
2e90ccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: