Retry Wrapper | WIP #19
Conversation
| @@ -65,8 +66,8 @@ public final class SalesforceBulkUtil { | |||
| * @throws AsyncApiException if there is an issue creating the job | |||
| */ | |||
|
|
|||
| public static JobInfo createJob(BulkConnection bulkConnection, String sObject, OperationEnum operationEnum, | |||
| @Nullable String externalIdField, | |||
| public static JobInfo createJob(BulkConnectionRetryWrapper bulkConnection, String sObject, | |||
There was a problem hiding this comment.
rename the field to bulkConnectionRetryWrapper
| @@ -164,7 +165,10 @@ public static List<SalesforceSplit> getSplits( | |||
| bulkConnection.addHeader(SalesforceSourceConstants.HEADER_ENABLE_PK_CHUNK, | |||
| String.join(";", chunkHeaderValues)); | |||
| } | |||
| List<SalesforceSplit> querySplits = SalesforceSplitUtil.getQuerySplits(query, bulkConnection, | |||
| BulkConnectionRetryWrapper bulkConnectionRetryWrapper = new BulkConnectionRetryWrapper(bulkConnection, | |||
There was a problem hiding this comment.
Rather than passing the bulkConnection here, write a method in SalesforceSplitUtil that returns RetryWrapper
| } | ||
|
|
||
| public JobInfo createJob(JobInfo jobInfo) throws AsyncApiException { | ||
| if (!retryOnBackendError) { |
There was a problem hiding this comment.
rather than adding if condition for each method, can we have a retry policy that dont try after failure. E.g maxAttempts = 1
| try { | ||
| return createBatchFromStream(query, job); | ||
| } catch (AsyncApiException e) { | ||
| throw new SalesforceQueryExecutionException(e.getMessage()); |
There was a problem hiding this comment.
SalesforceQueryExecutionException will only be thrown if error code is among the four which we were using previously, write a method that will handle AsyncAPIException and throw error only if code is among those and call that from all catches
|
As per new guidelines please get design doc approved before reviewing the PR. 😄 ✌️ |
Generating diff for branch: [feat/bulk-api-retry] against [develop]
Default Title
Jira : PLUGIN-0000
Description
Default Description
UI Field
Salesforce-batchsink.jsonDocs
Code change
BulkConnectionRetryWrapper.javaSalesforceBulkUtil.javaSalesforceOutputFormatProvider.javaSalesforceSinkConfig.javaSalesforceBatchMultiSource.javaSalesforceBatchSource.javaSalesforceBulkRecordReader.javaSalesforceSplitUtil.javaUnit Tests