Selected input scenarios for basic joins and advance scenarios for joiner #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahuldash171
force-pushed
the
Joiner_new_Features
branch
from
88a18ef
to
d2afad6
Compare
poojantcs
reviewed
Aug 25, 2023
| return SeleniumDriver.getDriver().findElement(By.xpath(xpath)); | ||
| } | ||
|
|
||
| public static WebElement requiredInputCheckboxFirstFile(String pluginName){ |
There was a problem hiding this comment.
Update: pluginName to input.
Remove the second locator and use the index as a parameter.
poojantcs
reviewed
Aug 25, 2023
| @@ -36,6 +36,16 @@ public void uncheckPluginFieldAliasCheckBox(String plugin, String field) { | |||
| JoinerActions.uncheckPluginFieldAliasCheckBox(plugin, field); | |||
| } | |||
|
|
|||
| @Then("Click on the required input checkbox for first schema {string}") | |||
There was a problem hiding this comment.
Add index and remove the second steps
There was a problem hiding this comment.
Done , removed second and used index
rahuldash171
force-pushed
the
Joiner_new_Features
branch
2 times, most recently
from
edb228e
to
c190827
Compare
Selected input scenarios for basic joins.
rahuldash171
force-pushed
the
Joiner_new_Features
branch
from
c190827
to
b049c8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests Covered :
Advance Inner Join
Advance Outer Join
Basic Inner Join with selected inputs
Basic outer join with selected inputs and required input