control center framework steps #13

priyabhatnagar25 · 2023-10-23T10:59:06Z

No description provided.

bharatgulati · 2023-10-25T06:29:33Z

src/main/java/io/cdap/e2e/pages/actions/CdfControlCenterActions.java

+    ElementHelper.clickOnElement(CdfControlCenterLocators.navigateControlCenterPage);
+  }
+
+  public static void clickCreateButtonControlCenterPage() {


clickOn*CreateButtonCenterPage()

bharatgulati · 2023-10-25T06:30:19Z

src/main/java/io/cdap/e2e/pages/locators/CdfControlCenterLocators.java

+  @FindBy(how = How.XPATH, using = "//div[@class='just-added-entities-list']//button[@class='btn btn-link']" +
+    "//*[@class='icon-svg icon-trash']")
+  public static WebElement clickDeleteIconControlCenter;
+  public static By clickDeleteButton()  {


clickOn*DeleteButton

rahuldash171 · 2023-10-25T07:45:14Z

src/main/java/stepsdesign/ControlCenterSteps.java

+  public void pipelinePresentControlCenterPage() {
+    CdfControlCenterActions.pipelinePresentControlCenterPage();
+  }
+  @Then("Verify user can click on the delete icon of the created pipeline and pipeline gets deleted successfully")


We are not verifying if the piplline is deleted or not , we are simply deleting it . Can we add the validation steps that after deleting the pipline is not present inside control center or something like that ?

Working for this

Working on it

rahuldash171 · 2023-10-25T07:46:57Z

src/main/java/io/cdap/e2e/pages/actions/CdfControlCenterActions.java

+  }
+
+  public static void clickOnHamburgerMenu() {
+    ElementHelper.clickOnElement(CdfControlCenterLocators.hamburgerMenu);


click on HamburgerMenu is used for Namespace admin cases also , If you can reuse the same no need to add new method here .

Ignore the above comment as we are raising the PRs individually .

rahuldash171 · 2023-10-25T07:51:29Z

src/main/java/io/cdap/e2e/pages/actions/CdfControlCenterActions.java

+    ElementHelper.clickOnElement(CdfControlCenterLocators.controlCenterMenu);
+  }
+
+  public static void navigateOnControlCenterTab() {


change the method Name to navigateToControlCenter()

rahuldash171 · 2023-10-25T07:52:34Z

src/main/java/io/cdap/e2e/pages/locators/CdfControlCenterLocators.java

+  public static WebElement controlCenterMenu;
+
+  @FindBy(how = How.XPATH, using = "//*[@data-cy='feature-heading'][//div[contains(text(),'Control Center')]]")
+  public static WebElement navigateControlCenterPage;


Change the locator name pageHeaderControlCenter

changed pageHeaderControlCenter

rahuldash171 · 2023-10-25T07:56:50Z

src/main/java/stepsdesign/ControlCenterSteps.java

+
+  private static final Logger logger = LoggerFactory.getLogger(ControlCenterSteps.class);
+
+  @Then("Click on the Hamburger bar on the left panel")


Remove this and use the namespace admin code

rahuldash171 · 2023-10-25T08:02:29Z

src/main/java/io/cdap/e2e/pages/locators/CdfControlCenterLocators.java

+  public static WebElement navigateControlCenterPage;
+
+  @FindBy(how = How.XPATH, using = "//span[contains(text(),'Create')]")
+  public static WebElement clickCreateButtonControlCenter;


remove click , it should be createButtonControlCenter

rahuldash171 · 2023-10-25T08:02:48Z

src/main/java/io/cdap/e2e/pages/locators/CdfControlCenterLocators.java

+  public static WebElement clickCreateButtonControlCenter;
+
+  @FindBy(how = How.XPATH, using = "//span[@class='entity-type'][//span[contains(text(),'Data Pipeline')]]")
+  public static WebElement clickDataPipelineControlCenter;


remove click

removed click

rahuldash171 · 2023-10-25T08:03:35Z

src/main/java/io/cdap/e2e/pages/locators/CdfControlCenterLocators.java

+
+  @FindBy(how = How.XPATH, using = "//div[@class='just-added-entities-list']//button[@class='btn btn-link']" +
+    "//*[@class='icon-svg icon-trash']")
+  public static WebElement clickDeleteIconControlCenter;


remove click

removed click

itsmekumari · 2023-10-26T10:37:49Z

src/main/java/io/cdap/e2e/pages/actions/CdfControlCenterActions.java

+  }
+
+  public static void clickOnDeleteButtonIfDisplayed() {
+    ElementHelper.clickIfDisplayed(CdfControlCenterLocators.clickDeleteButton());


We can use clickOnElement function

I have used this as its a alert box coming after clicking on the delete icon , so if it displyed then click on it

itsmekumari · 2023-10-26T10:44:41Z

src/main/java/io/cdap/e2e/pages/actions/CdfControlCenterActions.java

+    ElementHelper.clickOnElement(CdfControlCenterLocators.clickDataPipelineControlCenter);
+  }
+
+  public static void clickOnDeleteButtonIfDisplayed() {


Change method name to clickOnDeleteButtonOnConfirmationBox()

Changed clickOnDeleteButtonOnConfirmationBox

itsmekumari · 2023-10-26T11:06:56Z

src/main/java/io/cdap/e2e/pages/locators/CdfControlCenterLocators.java

+    "//*[@class='icon-svg icon-trash']")
+  public static WebElement clickDeleteIconControlCenter;
+  public static By clickDeleteButton()  {
+    return By.xpath("//button[@class='btn btn-primary'][//button[@data-cy='Delete']]");


We have a data-cy or data-test-id for this we can use it and create something like this : //div//button[@data-cy='Delete'] or //div//button[@data-testid='Delete']

Have used both things here class and data-cy also, i think thats fine.

Note - Class names are mostly defined by developers to apply styling/css on web pages and they can change them quite frequently while an UI update.

itsmekumari · 2023-10-26T11:18:57Z

src/main/java/io/cdap/e2e/pages/locators/CdfControlCenterLocators.java

+  @FindBy(how = How.XPATH, using = "//*[@data-cy='feature-heading'][//div[contains(text(),'Control Center')]]")
+  public static WebElement navigateControlCenterPage;
+
+  @FindBy(how = How.XPATH, using = "//span[contains(text(),'Create')]")


Try to use //*[@id='create-pipeline-link'] as we have id for element

Used //*[@id='create-pipeline-link']

itsmekumari · 2023-10-26T11:21:35Z

src/main/java/io/cdap/e2e/pages/locators/CdfControlCenterLocators.java

+  @FindBy(how = How.XPATH, using = "//*[@data-cy='navbar-hamburger-icon']")
+  public static WebElement hamburgerMenu;
+
+  @FindBy(how = How.XPATH, using = "//div[contains(text(),'Control Center')]")


Use data-cy or data-testid as it exists for this element

changed the loactor //*[@data-cy='navbar-control-center-link']

itsmekumari · 2023-10-27T06:23:36Z

src/main/java/io/cdap/e2e/pages/actions/CdfControlCenterActions.java

+  public static void  clickOnDeleteButtonOnConfirmationBox() {
+    ElementHelper.clickIfDisplayed(CdfControlCenterLocators.clickOnDeleteButton());
+  }
+  public static void deletePipelineControlCenter() {


itsmekumari · 2023-10-27T06:23:58Z

src/main/java/io/cdap/e2e/pages/actions/CdfControlCenterActions.java

+  public static void deletePipelineControlCenter() {
+    ElementHelper.clickOnElement(CdfControlCenterLocators.deleteIconControlCenter);
+    clickOnDeleteButtonOnConfirmationBox();
+


Remove extra line.

removed extra line

itsmekumari · 2023-10-27T06:24:41Z

src/main/java/io/cdap/e2e/pages/actions/CdfControlCenterActions.java

+    clickOnDeleteButtonOnConfirmationBox();
+
+  }
+  public static void pipelineDeletedIsNotPresent() {


Use formatter to resolve these line spacing.

done removed extraa lines

rahuldash171 · 2023-10-27T10:22:41Z

src/main/java/stepsdesign/ControlCenterSteps.java

+  @Then("Verify user is able to click on the create button to create a pipeline successfully")
+  public void createButtonControlCenterPage() {
+    CdfControlCenterActions.clickOnCreateButtonControlCenterPage();
+  }


add space here , avoid these kind of mistakes

rahuldash171 · 2023-10-27T10:22:57Z

src/main/java/stepsdesign/ControlCenterSteps.java

+  @Then("Verify the pipeline created successfully is present in control center page")
+  public void pipelinePresentControlCenterPage() {
+    CdfControlCenterActions.pipelinePresentControlCenterPage();
+  }


add space after this

rahuldash171 · 2023-10-27T10:23:37Z

src/main/java/io/cdap/e2e/pages/locators/CdfControlCenterLocators.java

+
+  @FindBy(how = How.XPATH, using = "//div[@class='just-added-entities-list']//button[@class='btn btn-link']" +
+    "//*[@class='icon-svg icon-trash']")
+  public static WebElement deleteIconControlCenter;


add space below

rahuldash171 · 2023-10-27T10:31:44Z

src/main/java/io/cdap/e2e/pages/actions/CdfControlCenterActions.java

+  }
+
+  public static void pipelineDeletedIsNotPresent() {
+    clickOnSearchTabControlCenter(PipelineSteps.pipelineName);


Is this step will search the recently deleted pipline ?

bharatgulati reviewed Oct 25, 2023

View reviewed changes

rahuldash171 reviewed Oct 25, 2023

View reviewed changes

itsmekumari reviewed Oct 26, 2023

View reviewed changes

itsmekumari reviewed Oct 27, 2023

View reviewed changes

priyabhatnagar25 force-pushed the e2e_controlcenter_tests branch from 0223396 to 0e38678 Compare October 27, 2023 08:35

rahuldash171 reviewed Oct 27, 2023

View reviewed changes

itsmekumari approved these changes Oct 27, 2023

View reviewed changes

priyabhatnagar25 force-pushed the e2e_controlcenter_tests branch from 0e38678 to 8e92307 Compare October 27, 2023 11:35

control center framework steps

4aa87ac

priyabhatnagar25 force-pushed the e2e_controlcenter_tests branch from 8e92307 to 4aa87ac Compare October 27, 2023 11:51


		private static final Logger logger = LoggerFactory.getLogger(ControlCenterSteps.class);

		@Then("Click on the Hamburger bar on the left panel")

control center framework steps #13

Are you sure you want to change the base?

control center framework steps #13

Conversation

priyabhatnagar25 commented Oct 23, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment