replaces ioutil to io #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazegusuri
reviewed
Nov 26, 2023
cmd/apply.go
Outdated
| "github.com/cloudspannerecosystem/wrench/pkg/spanner" | ||
| "github.com/spf13/cobra" | ||
| "os" |
There was a problem hiding this comment.
Please separate standard libraries and third party libraries by empty line and put this package to standard libraries group.
There was a problem hiding this comment.
Thank you for your review! I ran goimports and fixed the order!
|
I've addressed the imports problem and the test ci failed. However, upon review, I did not find any apparent issues relevant to the changes. Could you please rerun the CI to verify? Thank you. |
Shion1305
force-pushed
the
shion/replace-ioutil
branch
from
a7db3ee
to
2c71a29
Compare
|
@kazegusuri |
kazegusuri
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This PR replaces ioutil usages.
WHY
ioutil is deprecated from Golang 1.16.