Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(synthetics): Add elements operator to Synthetics Tests JSON Path assertion #109

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix(synthetics): Add elements operator to Synthetics Tests JSON Path assertion #109

merged 1 commit into from
Dec 2, 2024

Conversation

elx-bob
Copy link
Contributor

@elx-bob elx-bob commented Nov 27, 2024

what

  • Add missing field elementsoperator to Synthetics Tests' JSON Path Assertion.
  • Add missing field to both multi-step and overall Assertions.

why

  • The field elementsoperator appears to have been missed in the module.
  • When attempting to set elementsoperator, it always uses the default value of firstElementMatches, so we are unable to set other values, such as everyElementMatches.

references

@elx-bob elx-bob requested review from a team as code owners November 27, 2024 15:45
@elx-bob elx-bob requested review from kevcube and jamengual November 27, 2024 15:45
@mergify mergify bot added the triage Needs triage label Nov 27, 2024
@milldr milldr added minor New features that do not break anything and removed triage Needs triage labels Dec 2, 2024
@milldr
Copy link
Member

milldr commented Dec 2, 2024

/terratest

milldr
milldr approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@milldr milldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milldr milldr merged commit 7d63b7a into cloudposse:main Dec 2, 2024
72 of 86 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

These changes were released in v1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milldr milldr milldr approved these changes

@kevcube kevcube Awaiting requested review from kevcube kevcube is a code owner automatically assigned from cloudposse/contributors

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elx-bob @milldr