fix(synthetics): Adjust timeframes loop to include child objects (#107)

cloudposse · Oct 25, 2024 · c04a852 · c04a852
1 parent a3eea92
commit c04a852
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/examples/synthetics/versions.tf b/examples/synthetics/versions.tf
@@ -4,7 +4,7 @@ terraform {
   required_providers {
     datadog = {
       source  = "datadog/datadog"
-      version = "3.31.0"
+      version = ">=3.43.1"
     }
   }
 }
diff --git a/modules/synthetics/main.tf b/modules/synthetics/main.tf
@@ -405,7 +405,7 @@ resource "datadog_synthetics_test" "default" {
           # Required
           timezone = scheduling.value.timezone
           dynamic "timeframes" {
-            for_each = [for v in [lookup(scheduling.value, "timeframes", null)] : v if v != null]
+            for_each = lookup(scheduling.value, "timeframes", [])
 
             content {
               day  = timeframes.value.day

diff --git a/modules/synthetics/versions.tf b/modules/synthetics/versions.tf
@@ -3,8 +3,9 @@ terraform {
 
   required_providers {
     datadog = {
-      source  = "datadog/datadog"
-      version = ">= 3.31.0"
+      source = "datadog/datadog"
+      # Must have >= 3.43.1 to have fix for https://github.com/DataDog/terraform-provider-datadog/issues/2531
+      version = ">= 3.43.1"
     }
   }
 }
diff --git a/test/src/examples_complete_test.go b/test/src/examples_complete_test.go
@@ -104,7 +104,7 @@ func TestExamplesComplete(t *testing.T) {
 		}
 
 		// anomaly-recovery-test should have no tags
-		assert.Nil(t, output["anomaly-recovery-test"].(map[string]interface{})["tags"], "Monitor 'anomaly-recovery-test' should have no tags")
+		assert.Empty(t, output["anomaly-recovery-test"].(map[string]interface{})["tags"], "Monitor 'anomaly-recovery-test' should have no tags")
 
 		// schedule-legacy-test has no tags defined, should have default tags
 		tags, err = extractMonitorTags(output["schedule-legacy-test"])