Remove enabled ternary on providers

[tommij]

what

removal of enabled part of the for_each ternary, as it disables assume_role on enabled = false, which blocks teardown.

why

• local.enabled ternary causes no provider to be present on enabled = false, preventing teardown.

references

• closes enabled = false doesn't work with [requester|accepter]_aws_assume_role_arn because of enabled ternary on the provider definition #81
• Reverts Disable provider role assumption if enabled is false #56

[aknysh]

thanks @tommij

[aknysh]

thanks @tommij

[aknysh]

/terratest

[aknysh]

@tommij can you please run the following commands and commit the changes:

make init
make github/init
make readme

[aknysh]

please rebuild README again

[nitrocode]

Just note that this reverts #56 pr. Honestly we need to remove the providers from this module so the root terraform dir that consumes this module can fully control the provider.

See

• issue Module does not support for_each due to hard coded providers #48
• pr Remove provider config #49

[tommij]

Just note that this reverts #56 pr. Honestly we need to remove the providers from this module so the root terraform dir that consumes this module can fully control the provider.

See

• issue Module does not support for_each due to hard coded providers #48
• pr Remove provider config #49

Not necessarily in disagreement - but I also don't think providers should be be ternary enabled/disabled at any point, as that would effectively mean that you cannot remove resources created with the module. Resources is another thing entirely.

Fortunately, disabled was only the case for assume role parameters, and nothing else - on account of the implementation.

It seems we may have been the only ones using assume_role with role chaining that have tried to set enabled = false with this module, but we did eventually get there :)

[aknysh]

@tommij thank you, please address this:

README.md is outdated. Please run the following commands locally and push the file:
  make init
  make github/init
  make readme

We'll approve the PR since I agree with you that providers should not be disabled in any case (providers are not resources)

[aknysh]

please see comments

[aknysh]

/terratest

[aknysh]

thanks @tommij