Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(main.tf): handle enabled boolean in manage_rules #124

Merged
merged 6 commits into from
Jan 2, 2025
Merged

fix(main.tf): handle enabled boolean in manage_rules #124

merged 6 commits into from
Jan 2, 2025

Conversation

mikedizon
Copy link
Contributor

what

use enabled boolean in managed_rules variable

why

aws_config_config_rule resources were still being created despite enabled being set to false

@mikedizon mikedizon requested review from a team as code owners October 31, 2024 16:50
@mergify mergify bot added the triage Needs triage label Oct 31, 2024
@GabisCampana
Copy link

@aknysh
@milldr

@Benbentwo
Copy link
Member

/terratest

@Benbentwo
Copy link
Member

NOTE: Bats is an issue for the repo and not caused by this PR

johncblandii
johncblandii previously approved these changes Nov 12, 2024
View reviewed changes
@mergify mergify bot removed the triage Needs triage label Nov 12, 2024
@mergify mergify bot added the triage Needs triage label Jan 2, 2025
@mikedizon mikedizon requested a review from johncblandii January 2, 2025 15:37
@goruha
Copy link
Member

goruha commented Jan 2, 2025

/terratest

1 similar comment
@goruha
Copy link
Member

goruha commented Jan 2, 2025

/terratest

@goruha goruha merged commit 100b25c into cloudposse:main Jan 2, 2025
20 checks passed
@mergify mergify bot removed the triage Needs triage label Jan 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

These changes were released in v1.5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goruha goruha goruha approved these changes

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

@johncblandii johncblandii Awaiting requested review from johncblandii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikedizon @GabisCampana @Benbentwo @goruha @johncblandii