Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main.tf #17

Closed
wants to merge 1 commit into from
Closed

Update main.tf #17

wants to merge 1 commit into from

Conversation

max-lobur
Copy link
Contributor

what

  • Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)
  • Use bullet points to be concise and to the point.

why

  • Provide the justifications for the changes (e.g. business case).
  • Describe why these changes were made (e.g. why do these commits fix the problem?)
  • Use bullet points to be concise and to the point.

references

  • Link to any supporting github issues or helpful documentation to add some context (e.g. stackoverflow).
  • Use closes #123, if this PR closes a GitHub issue #123

@max-lobur max-lobur requested review from a team as code owners May 9, 2023 15:57
@github-actions
Copy link

github-actions bot commented May 9, 2023

README.md is outdated. Please run the following command locally and push the file.

make init 
make readme

@@ -1,4 +1,5 @@
resource "aws_cloudformation_stack" "default" {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[terraform fmt -recursive] reported by reviewdog 🐶

Suggested change

Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

@@ -1,4 +1,5 @@
resource "aws_cloudformation_stack" "default" {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  Ensure AWS CloudFormation stacks are sending event notifications to an SNS topic
    Resource: aws_cloudformation_stack.default | Bridgecrew ID: BC_AWS_LOGGING_25 | Checkov ID: CKV_AWS_124

How to Fix

  resource "aws_cloudformation_stack" "default" {
    name = "networking-stack"
    ...
 +  notification_arns = ["arn1", "arn2"]
  }

Description

Enabling event notifications for your AWS CloudFormation stacks can help you to monitor and track changes to your stacks. When event notifications are enabled, CloudFormation will send a message to an Amazon Simple Notification Service (SNS) topic each time a stack event occurs. By doing so, you will improve your visibility and automation processes (if desired).

@max-lobur max-lobur closed this May 9, 2023
@@ -1,4 +1,5 @@
resource "aws_cloudformation_stack" "default" {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  Ensure AWS CloudFormation stacks are sending event notifications to an SNS topic
    Resource: module.cloudformation_stack.aws_cloudformation_stack.default | Bridgecrew ID: BC_AWS_LOGGING_25 | Checkov ID: CKV_AWS_124

How to Fix

  resource "aws_cloudformation_stack" "default" {
    name = "networking-stack"
    ...
 +  notification_arns = ["arn1", "arn2"]
  }

Description

Enabling event notifications for your AWS CloudFormation stacks can help you to monitor and track changes to your stacks. When event notifications are enabled, CloudFormation will send a message to an Amazon Simple Notification Service (SNS) topic each time a stack event occurs. By doing so, you will improve your visibility and automation processes (if desired).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant