-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update main.tf #17
Update main.tf #17
Conversation
README.md is outdated. Please run the following command locally and push the file. make init
make readme |
@@ -1,4 +1,5 @@ | |||
resource "aws_cloudformation_stack" "default" { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[terraform fmt -recursive] reported by reviewdog 🐶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bridgecrew has found errors in this PR ⬇️
@@ -1,4 +1,5 @@ | |||
resource "aws_cloudformation_stack" "default" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure AWS CloudFormation stacks are sending event notifications to an SNS topic
Resource: aws_cloudformation_stack.default | Bridgecrew ID: BC_AWS_LOGGING_25
| Checkov ID: CKV_AWS_124
How to Fix
resource "aws_cloudformation_stack" "default" {
name = "networking-stack"
...
+ notification_arns = ["arn1", "arn2"]
}
Description
Enabling event notifications for your AWS CloudFormation stacks can help you to monitor and track changes to your stacks. When event notifications are enabled, CloudFormation will send a message to an Amazon Simple Notification Service (SNS) topic each time a stack event occurs. By doing so, you will improve your visibility and automation processes (if desired).@@ -1,4 +1,5 @@ | |||
resource "aws_cloudformation_stack" "default" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure AWS CloudFormation stacks are sending event notifications to an SNS topic
Resource: module.cloudformation_stack.aws_cloudformation_stack.default | Bridgecrew ID: BC_AWS_LOGGING_25
| Checkov ID: CKV_AWS_124
How to Fix
resource "aws_cloudformation_stack" "default" {
name = "networking-stack"
...
+ notification_arns = ["arn1", "arn2"]
}
what
why
references
closes #123
, if this PR closes a GitHub issue#123