Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide SSL security policy #45

Merged
merged 6 commits into from
Jun 20, 2022
Merged

Provide SSL security policy #45

merged 6 commits into from
Jun 20, 2022

Conversation

richardj-bsquare
Copy link
Contributor

@richardj-bsquare richardj-bsquare commented May 10, 2019 •
edited by nitrocode
Loading

what

Fixes the following error:

  • aws_elastic_beanstalk_environment.default: Error waiting for Elastic Beanstalk Environment (e-kiusnj9mi2) to become ready: 2 errors occurred:
    • 2019-05-10 12:08:15.882 +0000 UTC (e-kiusnj9mi2) : Stack named 'awseb-e-kiusnj9mi2-stack' aborted operation. Current state: 'CREATE_FAILED' Reason: The following resource(s) failed to create: [AWSEBV2LoadBalancerListener443].
    • 2019-05-10 12:08:15.983 +0000 UTC (e-kiusnj9mi2) : Creating Load Balancer listener failed Reason: An SSL policy must be specified for HTTPS listeners (Service: AmazonElasticLoadBalancingV2; Status Code: 400; Error Code: ValidationError; Request ID: 43157996-731c-11e9-891f-117f22424633)

Which has been reported as an issue on the upstream project: cloudposse/terraform-aws-elastic-beanstalk-environment#81

references

@richardj-bsquare richardj-bsquare mentioned this pull request May 16, 2019
Closed
@richardj-bsquare
Copy link
Contributor Author

Addresses #46

aknysh
aknysh previously requested changes May 17, 2019
View reviewed changes
Copy link
Contributor

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @richardj-bsquare

Looks good, but please rebuild README by executing these commands:

make init
make readme/deps
make readme

It will add the new variables and outputs to README.md automatically.

In general, any changes to README should be made in README.yaml (not in this case), and after that executing the commands above will rebuild README.yaml into README.md and add all new variables and outputs to README.md

thanks

@richardj-bsquare
Copy link
Contributor Author

Review comments addressed.

@chris-str-cst
Copy link

Can we please merge this fix?

@chris-str-cst
Copy link

@aknysh Is it now ok?

andrewjeck
andrewjeck reviewed Nov 11, 2019
View reviewed changes
Copy link

@andrewjeck andrewjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does fix the issue described. It would be cool if it backported into 0.6.0 and terraform registry as the deployment fails without these.

@rdelcampog
Copy link

Please, backport to 0.6.0 and upgrade registry.

@mergify
Copy link

mergify bot commented Jan 6, 2021

This pull request is now in conflict. Could you fix it @richardj-bsquare? 🙏

@nitrocode nitrocode requested review from a team as code owners June 20, 2022 23:01
@nitrocode nitrocode requested a review from a team as a code owner June 20, 2022 23:01
@nitrocode nitrocode requested review from jhosteny and Benbentwo and removed request for a team June 20, 2022 23:01
@mergify mergify bot dismissed aknysh’s stale review June 20, 2022 23:01

This Pull Request has been updated, so we're dismissing all reviews.

@nitrocode
Copy link
Contributor

/test all

@nitrocode nitrocode merged commit 4ae2c93 into cloudposse-archives:master Jun 20, 2022
@nitrocode
Copy link
Contributor

Thanks for the update @richardj-bsquare ! Sorry for the long wait. I made some updates in order to expose this input to this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewjeck andrewjeck andrewjeck left review comments

@nitrocode nitrocode nitrocode approved these changes

@aknysh aknysh aknysh left review comments

@jhosteny jhosteny Awaiting requested review from jhosteny jhosteny was automatically assigned from cloudposse/contributors

@Benbentwo Benbentwo Awaiting requested review from Benbentwo Benbentwo was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide SSL security Policy
7 participants
@richardj-bsquare @chris-str-cst @rdelcampog @nitrocode @aknysh @andrewjeck @cloudpossebot