feat(ci): add release workflow and align CI with go-makefile-maker#66
Open
onuryilmaz wants to merge 1 commit into
Open
feat(ci): add release workflow and align CI with go-makefile-maker#66onuryilmaz wants to merge 1 commit into
onuryilmaz wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository’s CI and linting workflows to call reusable Go workflows from cloudoperators/common, reducing duplicated workflow logic while retaining the existing PR coverage-comment job and non-Go checks.
Changes:
- Replaced inline
buildandtestjobs inci.yamlwithcloudoperators/commonreusable workflows. - Extracted Go linting +
govulncheckinto a dedicatedlintjob using a shared workflow inchecks.yaml. - Pinned several third-party GitHub Actions used by the remaining inline jobs to full SHAs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/ci.yaml | Delegates Go build/test to shared workflows; keeps inline PR coverage reporting with pinned actions. |
| .github/workflows/checks.yaml | Adds a shared-workflow lint job; keeps existing inline non-Go checks and pins actions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
onuryilmaz
force-pushed
the
feat/shared-workflows
branch
from
a699d96 to
8bc01f6
Compare
onuryilmaz
force-pushed
the
feat/shared-workflows
branch
2 times, most recently
from
96b4fc8 to
f3268ae
Compare
onuryilmaz
changed the title
onuryilmaz
force-pushed
the
feat/shared-workflows
branch
from
9f4f395 to
82468e5
Compare
- Add release workflow delegating to cloudoperators/common shared-release - Add govulncheck to dependency findings; bump golang.org/x/* and go directive to 1.26.4 to resolve stdlib findings - Configure Makefile.maker.yaml to own VERSION and envtest wiring via verbatim, and disable setGoModVersion to preserve go 1.26.4 patch - Use go-makefile-maker generated ci.yaml and checks.yaml as-is (inline jobs); release.yaml remains manually maintained Signed-off-by: Onur Yılmaz <onur.yilmaz@sap.com>
onuryilmaz
force-pushed
the
feat/shared-workflows
branch
from
82468e5 to
ccff868
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/release.yamldelegating tocloudoperators/common/.github/workflows/shared-release.yaml@mainfor version bump releases (patch/minor/major viaworkflow_dispatch)golang.org/x/*dependencies and pinsgo 1.26.4ingo.modto resolve govulncheck stdlib findingsMakefile.maker.yamlwith go-makefile-maker conventions:VERSION = 0.3.0and envtest wiring forbuild/cover.outmanaged viaverbatimso they survive regenerationsetGoModVersion: falseto preserve thego 1.26.4patch versionci.yamlandchecks.yamlnow use go-makefile-maker generated inline jobs as-isTest plan
bump: patchto validate end-to-end