-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#124 update makefiles & build-libs #125
#124 update makefiles & build-libs #125
Conversation
ba04cab
to
dcd19cc
Compare
dcd19cc
to
54aa591
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks for that! 💙
Personally, I like the simplicity of the solution. I found some issues regarding the refactoring and some text elements but nothing serious which will be discussed in my annotations below.
Co-authored-by: Philipp Pixel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you so much 💙
Co-authored-by: Benjamin Ernst <[email protected]>
closes #124