Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#124 update makefiles & build-libs #125

Merged

Conversation

kahoona77
Copy link
Contributor

closes #124

@kahoona77 kahoona77 linked an issue Mar 18, 2025 that may be closed by this pull request
@kahoona77 kahoona77 force-pushed the bugfix/124-fix-project-permissions-does-not-work-in-ces-mn branch 2 times, most recently from ba04cab to dcd19cc Compare March 19, 2025 15:14
@kahoona77 kahoona77 force-pushed the bugfix/124-fix-project-permissions-does-not-work-in-ces-mn branch from dcd19cc to 54aa591 Compare March 19, 2025 15:16
@kahoona77 kahoona77 changed the title WIP #124 update makefiles & build-libs #124 update makefiles & build-libs Mar 20, 2025
Copy link
Member

@ppxl ppxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for that! 💙

Personally, I like the simplicity of the solution. I found some issues regarding the refactoring and some text elements but nothing serious which will be discussed in my annotations below.

@kahoona77 kahoona77 requested a review from ppxl March 25, 2025 08:47
Copy link
Member

@ppxl ppxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much 💙

@ppxl ppxl merged commit 46d73ba into develop Mar 27, 2025
1 check passed
@ppxl ppxl deleted the bugfix/124-fix-project-permissions-does-not-work-in-ces-mn branch March 27, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Fix project permissions" does not work in CES MN
2 participants