Fix Operator status panels #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only one query is requires kube_pod_labels - operator ready replicas. This metric by default on most of setups is not available. This PR implement: - other way to achieve same result without relying on turned-off by default metric - more targeted operatorNamespace selector which is limited by webhook that unique to CloudNative-PG Signed-off-by: Dmitriy Alekseev <[email protected]>
Closed
2 tasks
dragoangel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes displaying status of Operator by using
kube_pod_status_ready == 1and remove requirement of having kube_pod_labels.Also it provide more targeted operatorNamespace selector which is limited by webhook that unique to CloudNative-PG
kube_pod_labels will be still needed for
topology.kubernetes.io/zone, but this usecase can't work without knowing labels, and well - it already has good(i)description, so it will relatively easy for users to utilize it if they already managed to createtopology.kubernetes.io/zoneaware cluster.