Fix ArgoCD diff on postgresql keys #441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bozorgmehr96
force-pushed
the
argocd_diff
branch
from
9048090
to
6fb2639
Compare
|
If there are other problems like this, give me the key names, and I will fix them. |
|
@bozorgmehr96 this is my ignoreDifferences rule: group: postgresql.cnpg.io
kind: Cluster
jsonPointers:
- /spec/bootstrap/initdb/postInitApplicationSQL
- /spec/managed
- /spec/postgresql/shared_preload_libraries
- /spec/priorityClassName
- /spec/postgresql/pg_hba
- /spec/postgresql/pg_identYou covered the last two for me |
|
@pschichtel Thanks. I wrapped them in if blocks. |
bozorgmehr96
force-pushed
the
argocd_diff
branch
2 times, most recently
from
13ae008
to
f8e49c2
Compare
added 6 commits
November 8, 2024 22:31
Signed-off-by: Mohammad Bozorgmehr <[email protected]>
Signed-off-by: Mohammad Bozorgmehr <[email protected]>
Signed-off-by: Mohammad Bozorgmehr <[email protected]>
Signed-off-by: Mohammad Bozorgmehr <[email protected]>
Signed-off-by: Mohammad Bozorgmehr <[email protected]>
Signed-off-by: Mohammad Bozorgmehr <[email protected]>
bozorgmehr96
force-pushed
the
argocd_diff
branch
from
f8e49c2
to
d08bd5a
Compare
|
@bozorgmehr96 one more: |
|
@pschichtel, can you provide a repro? It has a non-empty default value, so it shouldn't have the problem I'm trying to fix here. |
|
@bozorgmehr96 I customized the schedule, so I don't get the defaults since it's an array. According to charts/charts/cloudnative-pg/templates/crds/crds.yaml Line 15655 in fb45e4f charts/charts/cloudnative-pg/templates/crds/crds.yaml Line 15575 in fb45e4f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
withfor every key in the cluster'sspec.postgresqlto prevent generating empty keys.Fixes: #426