feat(cluster): added support for enablePDB option #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbugeia
force-pushed
the
dev/395
branch
2 times, most recently
from
ff942b1 to
e92bfad
Compare
|
@mbugeia Could you add the option to the non default configuration test that verifies that options are passed correctly? You'll need to set it to |
Signed-off-by: Maxime Bugeia <[email protected]>
|
@itay-grudev Thanks for the review, I've added the test. Unfortunatly I'm not sure if it works as I don't know how to run the tests locally 🙈 |
itay-grudev
approved these changes
Dec 7, 2024
yremmet
pushed a commit
to yremmet/charts
that referenced
this pull request
Dec 9, 2024
Signed-off-by: Maxime Bugeia <[email protected]> Co-authored-by: Itay Grudev <[email protected]>
hapeho
pushed a commit
to hapeho/cloudnative-pg-charts
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Maxime Bugeia <[email protected]> Co-authored-by: Itay Grudev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for enablePDB configuration option
Fix #395