Allow usage of strings in autoFocus.focusOn (#61)

cloudinary · Oct 3, 2024 · 6558301 · 6558301
1 parent 91e8568
commit 6558301
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/__TESTS__/unit/values/gravity/Gravity.test.ts b/__TESTS__/unit/values/gravity/Gravity.test.ts
@@ -1,4 +1,5 @@
-import {Gravity} from "../../../../src/qualifiers/gravity";
+import {Gravity, autoGravity} from "../../../../src/qualifiers/gravity";
+import {focusOn} from "../../../../src/qualifiers/autoFocus";
 import {crop} from "../../../../src/actions/resize";
 import {Transformation} from "../../../../src";
 
@@ -16,4 +17,12 @@ describe('Gravity Qualifier', () => {
         .gravity('auto')).toString();
     expect(tx).toContain('c_crop,g_auto,h_250,w_250');
   });
+  it('Can use any string in autoFocus.focusOn()', ()=>{
+    const tx = new Transformation()
+      .resize(crop()
+        .width(250)
+        .height(250)
+        .gravity(autoGravity().autoFocus(focusOn("ball")))).toString();
+    expect(tx).toContain('c_crop,g_auto:ball,h_250,w_250');
+  });
 });
diff --git a/src/qualifiers/autoFocus.ts b/src/qualifiers/autoFocus.ts
@@ -26,8 +26,9 @@ class AutoFocus extends QualifierValue {
    * @param {Qualifiers.FocusOn} obj The object to focus on.
    * @param {number} weight
    */
-  static focusOn(obj: FocusOnValue, weight?: number): AutoFocus {
-    return new AutoFocus(obj, weight);
+  static focusOn(obj: FocusOnValue | string, weight?: number): AutoFocus {
+    const focusOn = obj instanceof FocusOnValue ? obj : new FocusOnValue(obj);
+    return new AutoFocus(focusOn, weight);
   }
 
   constructor(focusOn: FocusOnValue, weight?: number | string) {