Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.txt #355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update readme.txt #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,8 @@ And with advanced digital asset management capabilities available in the plugin,
* [Video transformations documentation](https://cloudinary.com/documentation/video_manipulation_and_delivery?utm_source=wp&utm_medium=wpmarketplace&utm_campaign=wpmarketplace)
* [FAQ](http://cloudinary.com/faq?utm_source=wp&utm_medium=wpmarketplace&utm_campaign=wpmarketplace)

= Contributors & Developers =
“Cloudinary – Image and Video Optimization, Manipulation, and Delivery” is an open source software. The following people have contributed to this plugin:
[Cloudinary](https://profiles.wordpress.org/cloudinary/)
[XWP](https://profiles.wordpress.org/xwp/)
[Automattic](https://profiles.wordpress.org/automattic/)
= Notes =
The legacy WordPress Plugin version (v1.x) will be deprecated as of February 1st, 2021, after which support, updates and bug fixes for the legacy plugin will continue in limited fashion. The legacy plugin will be made obsolete on August 1st, 2021 (end-of-life date) and will no longer function after that date.
Comment on lines +56 to +57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marissa-masangcay , why is that overriding the Contributors & Developers section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I added it in the notes, but we have that mentioned down below in another section with the same title right after 'FAQ' so it's listed twice on the page. It was something I meant to correct a while back so just doing it now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I misunderstood on the file how it's laid out and should be corrected elsewhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand what you tried to fix... Couldn't find anything duplicated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slacked you a screenshot of what I was referring to a while back. Let me know if you need any further clarification. I may have just not edited the right portion, I'm not exactly sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marissa-masangcay , sorry... I didn't connect the slack to this thread.
I don't see any other Contributors & Developers section in the readme, so I concern that removing this will remove that section all together.
@pereirinha , wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asisayag2 @marissa-masangcay

I think that Marissa is right. By checking other plugins I've in the WP repo, it seems that the last section on the plugin landing page titled Contributors & Developers is auto-generated, meaning that there's no need to have that expressed in the readme.txt.

Worst case scenario, if it breaks, we can always add it back :)



== Installation ==
Expand Down