Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLD-48-organization-content #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

asad-rafter
Copy link
Contributor

No description provided.

metadata/global.xml Outdated Show resolved Hide resolved
var changedAssetIds = jobStepHelpers.changePublicIdAndCloudFolder(assetPublicID, folder);
assetPublicID = changedAssetIds.assetPublicID;
var svcArgs = jobStepHelpers.getCldUploadSvcArgs();
jobStepHelpers.uploadFile(cloudinaryConstants, url, null, folder, assetPublicID, null, svcArgs, null);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this where we get 401? Can you share the log line, filename and the timestamp so I can triage it in the Cloudinary logs?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asad-rafter Thanks for the code change. Please share the output of it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuval-cloudinary output means the logs you want?

Copy link
Collaborator

@yuval-cloudinary yuval-cloudinary Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes @asad-rafter , the new logs with the 401

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuval-cloudinary we are still getting the 401, cloudinary is still trying to access the content and it returns the 401. I have attached the latest logs.
Job-custom.cloudinary.UploadOrgStaticContent-a90b2e248d351a08de8a632441.log

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asad-rafter Was the 401 issue resolved after removing the environment protection?

@asad-rafter
Copy link
Contributor Author

@yuval-cloudinary the requested changes have been made

@yuval-cloudinary yuval-cloudinary self-requested a review January 14, 2025 12:13
@@ -178,7 +178,7 @@ var uploadFile = function (cloudinaryConstants, asset, tags, assignedFolder, ass
if (uploadResult.errorCode === cloudinaryConstants.ERROR_CODES.UNAUTHORIZED) {
jobLogger.error('Error occurred while connecting with service due to invalid credentials, message: {0}', uploadResult.message);
} else {
jobLogger.error('Error uploading file: {0}, message: {1}', asset, uploadResult.message);
jobLogger.error('jobStepHelpers~uploadFile: Error uploading file: {0}, message: {1}, line number 177', asset, uploadResult.message);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asad-rafter Let's revert this line for log message consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants